Add additional test and remove dead code#131
Merged
nporter-adbe merged 4 commits intoadobe:devfrom Jan 14, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #131 +/- ##
==========================================
+ Coverage 93.08% 93.18% +0.10%
==========================================
Files 18 18
Lines 578 601 +23
==========================================
+ Hits 538 560 +22
- Misses 40 41 +1 |
emdobrin
reviewed
Jan 13, 2021
Contributor
Author
|
Elected to just re-write the entire |
emdobrin
reviewed
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a real fatal error response test I received from Konductor by providing an invalid config id. This PR doesn't fix any bugs, but rather adds a new test and does some minor clean up.
I also took a minute to take another look at some of the decoding code, and realized that the decoding within the
guardis redundant, and checking iferrorsis nil is sufficient. In the case a generic fetal error is returned, it will end up decoding into anilEdgeErrorResponse, then when we checkredgeErrorResponse.errorswe'll realize that we need to decode it as a generic error.