Skip to content

Remove setters for extension properties#130

Merged
emdobrin merged 1 commit intoadobe:devfrom
emdobrin:cleanup
Jan 13, 2021
Merged

Remove setters for extension properties#130
emdobrin merged 1 commit intoadobe:devfrom
emdobrin:cleanup

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2021

Codecov Report

Merging #130 (036beed) into dev (93446d2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #130   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          18       18           
  Lines         578      578           
=======================================
  Hits          538      538           
  Misses         40       40           

@emdobrin
Copy link
Copy Markdown
Contributor Author

@nporter-adbe I noticed that the testSendEvent_fatalError test failed in the first run (https://app.circleci.com/pipelines/github/adobe/aepsdk-edge-ios/344/workflows/254bce4d-00a7-47d6-9ea3-e9e45a9b0162/jobs/367), can you take a look sometime?

@nporter-adbe
Copy link
Copy Markdown
Contributor

nporter-adbe commented Jan 12, 2021

@emdobrin Ran it several times locally and didn't see it fail.

I noticed it's actually failing in the test setup not within the test itself. I wonder if we'll see this popup for various different functional tests in the future.

[FunctionalTests.AEPEdgeFunctionalTests testSendEvent_fatalError] : XCTAssertFalse failed - Timed out waiting for event type com.adobe.eventType.hub and source com.adobe.eventSource.sharedState, expected 4, but received 3

From this expectation

// hub shared state update for 2 extension versions (InstrumentedExtension (registered in FunctionalTestBase), Identity, Edge), Identity and Config shared state updates
setExpectationEvent(type: FunctionalTestConst.EventType.HUB, source: FunctionalTestConst.EventSource.SHARED_STATE, expectedCount: 4)

@emdobrin emdobrin merged commit 6bf4770 into adobe:dev Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants