Conversation
Attempt to fix CI
* Add query parameter * revert some change * remove spm * functional test * fix comments * fix unnecessary code Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com> Co-authored-by: jgeng <jgeng@adobe.com>
* Get hits persisted, need to finish tests * Update core ref and fix typos * Add EdgeHitProcessorTests * Close hit queue on unregister * Clean persistent queue after each test * Minor refactoring, fix a few warnings * Format and fix warnings * re-add try's * Update config.yml * Add functional tests for persistent functionality * First round of PR comments (logs, function names, comments) * Move URL generaetion into hit processor * Make EdgeNetworkService async and address other PR comments * Attempt to fix test on CI * Increase network timeout * Rewrite assertions in new functional tests * Increase timeout * Improve test * assert failing network requests * Remove unused code * Extract retry interval to constant * Add 207 recoverable error code, fix test names * Move all hit building into HitProcessor * Downgrade some types from Codable, fix hit processor tests * Fix test names * Check ready for event before procesing hits, add more hit processor tests * Add test for nil config * Remove event from EdgeHit, remove redundent log
…dle (#109) * Set event type with the handle type on Edge response evevnts * Swap type and source when attaching handle type * Add tests for empty handle type and missing handle type. * Add clarifying comment
Co-authored-by: jgeng <jgeng@adobe.com>
nporter-adbe
approved these changes
Dec 17, 2020
Contributor
nporter-adbe
left a comment
There was a problem hiding this comment.
looks good.
@emdobrin are we ready to merge dev to main?
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 89.53% 91.11% +1.59%
==========================================
Files 16 17 +1
Lines 573 619 +46
==========================================
+ Hits 513 564 +51
+ Misses 60 55 -5 |
kevinlind
reviewed
Dec 17, 2020
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Let's update SampleApps/AEPCommerceDemoApp/Podfile.lock with the latest as well.
emdobrin
reviewed
Dec 21, 2020
emdobrin
approved these changes
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: