Skip to content

Merge to Staging for v2.3.0 release#86

Merged
kevinlind merged 7 commits intostagingfrom
dev-v2.3.0
Aug 25, 2023
Merged

Merge to Staging for v2.3.0 release#86
kevinlind merged 7 commits intostagingfrom
dev-v2.3.0

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Merge to Staging for 2.3.0 release:

  • Dispatch a complete event when an Edge Network request is complete. The complete event is only dispatched when requested by the original request event.
  • [chore] Fix lint warnings in Gradle files

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 7 commits July 21, 2023 13:34
Merge to Main for 2.2.0 release
* Fix deprecated use of

* Fix Groovy warnings in build files
* Send 'complete' event after all response handles are recieved when requested

* Update event source variable names to match source name 'CONTENT_COMPLETE'

* Reword method description for sendCompletionRequested

* Add more tests to bump coverage numbers

* Add Content Complete event to event-reference documentation

* Update event-reference with sendCompletion property and response content definition.

* Capitalize 'Defined' in table for completion event description
Add content complete event to toc, update response content description
@kevinlind kevinlind requested review from addb and timkimadobe August 24, 2023 22:22
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2023

Codecov Report

Merging #86 (5d322f8) into staging (2daf212) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             staging      #86      +/-   ##
=============================================
+ Coverage      83.63%   83.84%   +0.21%     
- Complexity       380      385       +5     
=============================================
  Files             29       29              
  Lines           1582     1578       -4     
  Branches         225      223       -2     
=============================================
  Hits            1323     1323              
+ Misses           162      161       -1     
+ Partials          97       94       -3     
Flag Coverage Δ
functional-tests 66.48% <92.31%> (+0.29%) ⬆️
unit-tests 79.78% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...java/com/adobe/marketing/mobile/EdgeConstants.java 100.00% <ø> (ø)
...a/com/adobe/marketing/mobile/EdgeHitProcessor.java 87.22% <100.00%> (-0.37%) ⬇️
...adobe/marketing/mobile/NetworkResponseHandler.java 84.62% <100.00%> (+1.71%) ⬆️

Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kevinlind kevinlind merged commit 54e3121 into staging Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants