Skip to content

Implemented overwrite custom path feature along with unit and functional tests#51

Merged
kevinlind merged 2 commits intoadobe:dev-v2.0.1from
addb:pathOverwrite
Mar 10, 2023
Merged

Implemented overwrite custom path feature along with unit and functional tests#51
kevinlind merged 2 commits intoadobe:dev-v2.0.1from
addb:pathOverwrite

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Mar 7, 2023

  • Implemented overwrite custom path feature
  • Refactored EdgeEndpoint class to take in RequestType and append to the URL
  • Added and updated tests for the feature and the refactor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…nal test. Also refactored EdgeEndpoint and EdgeHit classes.
@addb addb requested review from emdobrin and kevinlind March 7, 2023 02:26
@addb addb linked an issue Mar 7, 2023 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2023

Codecov Report

Merging #51 (563319b) into dev-v2.0.1 (925540f) will increase coverage by 0.01%.
The diff coverage is 90.00%.

@@               Coverage Diff                @@
##             dev-v2.0.1      #51      +/-   ##
================================================
+ Coverage         83.28%   83.29%   +0.01%     
- Complexity          367      378      +11     
================================================
  Files                29       29              
  Lines              1555     1580      +25     
  Branches            219      226       +7     
================================================
+ Hits               1295     1316      +21     
- Misses              161      164       +3     
- Partials             99      100       +1     
Flag Coverage Δ
functional-tests 65.95% <83.33%> (+0.10%) ⬆️
unit-tests 79.30% <90.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/com/adobe/marketing/mobile/EdgeConstants.java 100.00% <ø> (ø)
...com/adobe/marketing/mobile/EdgeNetworkService.java 73.68% <ø> (-0.14%) ⬇️
...src/main/java/com/adobe/marketing/mobile/Edge.java 60.87% <66.67%> (ø)
...a/com/adobe/marketing/mobile/EdgeHitProcessor.java 85.42% <88.89%> (-0.18%) ⬇️
.../java/com/adobe/marketing/mobile/EdgeEndpoint.java 97.83% <90.00%> (-2.17%) ⬇️
...java/com/adobe/marketing/mobile/EdgeExtension.java 85.26% <100.00%> (ø)
.../main/java/com/adobe/marketing/mobile/EdgeHit.java 100.00% <100.00%> (+8.33%) ⬆️
...va/com/adobe/marketing/mobile/ExperienceEvent.java 80.49% <100.00%> (ø)
...adobe/marketing/mobile/NetworkResponseHandler.java 82.14% <100.00%> (ø)
...ava/com/adobe/marketing/mobile/RequestBuilder.java 84.31% <100.00%> (+0.31%) ⬆️

@kevinlind kevinlind merged commit 5642c46 into adobe:dev-v2.0.1 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow path overwrite for EdgeMedia requests

2 participants