Skip to content

Update event reference doc#48

Merged
timkimadobe merged 14 commits intoadobe:dev-v2.0.1from
timkimadobe:update-event-reference
Feb 22, 2023
Merged

Update event reference doc#48
timkimadobe merged 14 commits intoadobe:dev-v2.0.1from
timkimadobe:update-event-reference

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Feb 17, 2023

Description

This PR updates:

  1. The event reference data payload column name to Required (the context is already data payload keys)
  2. Remove whitespace padding from tables
  3. Update consents table for clarity
  4. Update headers for clarity
  5. Update api section wording

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe changed the base branch from main to dev-v2.0.1 February 17, 2023 22:21
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2023

Codecov Report

Merging #48 (606e6ea) into dev-v2.0.1 (f487fce) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.0.1      #48   +/-   ##
=============================================
  Coverage         83.28%   83.28%           
  Complexity          367      367           
=============================================
  Files                29       29           
  Lines              1555     1555           
  Branches            219      219           
=============================================
  Hits               1295     1295           
  Misses              161      161           
  Partials             99       99           
Flag Coverage Δ
functional-tests 65.85% <ø> (ø)
unit-tests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Remove whitespace padding from tables
@timkimadobe timkimadobe changed the title Update event reference column name Update event reference doc Feb 17, 2023
@@ -23,31 +23,32 @@ The following events are handled by the Edge extension client-side.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge request content

This event is a request to process and deliver an Experience event to Edge Network. This event is captured by the Edge Network extension's event listener in the Event Hub for processing and sent to Edge Network.

If the required xdm key is not present in the event data payload, the event is not sent to Edge Network. To learn more about Experience Data Model (XDM), please read the XDM system overview​.

Event dispatched by

Event details

Event type Event source
com.adobe.eventType.edge com.adobe.eventSource.requestContent

Event data payload definition

Key Value type Required Description
xdm Map<String, Object> Yes XDM formatted data; use an XDMSchema implementation for better XDM data ingestion and data format control.
data Map<String, Object> No Optional free-form data associated with this event.
datasetId String No Optional custom dataset ID. If not set, the event uses the default Experience dataset ID set in the datastream configuration.

Note
Events of this type and source are only processed if the data collection consent status stored in the collect property is not n (no); that is, either y (yes) or p (pending).

Update ordering of subsections for each event type with dispatched by api
| --- | ---------- | -------- | ----------- |
| scope | `String` | No | The scope that the location hint applies to, for example `EdgeNetwork`. |
| hint | `String` | No | The location hint string. |
| ttlSeconds | `Integer` | No | The time period the location hint should be valid for. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int

Copy link
Copy Markdown
Contributor Author

@timkimadobe timkimadobe Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: never mind, the return type is int haha

In this case I used Integer because the DataReader.getInt implementation uses that type; should it be int instead?:

public static int getInt(Map<String, ?> map, String key) throws DataReaderException {
        Integer ret = (Integer)getTypedObject(Integer.class, map, key);
        if (ret == null) {
            throw new DataReaderException("Map contains null value for key");
        } else {
            return ret;
        }
    }

### Edge event response
### Edge response content

This event is a response to an event.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add which event: ex: edgerequestcontent

update data type to int
@addb addb self-requested a review February 18, 2023 01:27
@timkimadobe timkimadobe merged commit 3bcb26c into adobe:dev-v2.0.1 Feb 22, 2023
@timkimadobe timkimadobe deleted the update-event-reference branch February 22, 2023 02:01
@timkimadobe timkimadobe linked an issue Feb 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - getting started, event reference

2 participants