Skip to content

Edge test app in kotlin#37

Merged
emdobrin merged 4 commits intoadobe:dev-v2.0.0from
emdobrin:testappkt
Jan 30, 2023
Merged

Edge test app in kotlin#37
emdobrin merged 4 commits intoadobe:dev-v2.0.0from
emdobrin:testappkt

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented Jan 30, 2023

Description

  • Adds a new app-kotlin target for testing Edge SDKs in Kotlin. The app provides similar functionality with the java test app.
  • Moves Commerce XDM formatters to a util library app-util-xdm to be shared across test apps.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screen Shot 2023-01-29 at 7 47 36 PM
Screen Shot 2023-01-29 at 7 47 45 PM
Screen Shot 2023-01-29 at 7 48 09 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@emdobrin emdobrin linked an issue Jan 30, 2023 that may be closed by this pull request
Kotlin test app for integration testing #20
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Merging #37 (a86cafc) into dev-v2.0.0 (8f074dc) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v2.0.0      #37   +/-   ##
=============================================
  Coverage         83.28%   83.28%           
  Complexity          367      367           
=============================================
  Files                29       29           
  Lines              1555     1555           
  Branches            219      219           
=============================================
  Hits               1295     1295           
  Misses              161      161           
  Partials             99       99
Flag Coverage Δ
functional-tests 65.85% <ø> (ø)
unit-tests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@emdobrin emdobrin requested a review from addb January 30, 2023 19:28
addb
addb reviewed Jan 30, 2023
View reviewed changes
code/app-util-xdm/build.gradle
}

dependencies {
implementation project(':edge')
Copy link
Copy Markdown
Contributor

@addb addb Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need edge as a dependency here?

Copy link
Copy Markdown
Contributor Author

@emdobrin emdobrin Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for Schema and Property references

addb
addb reviewed Jan 30, 2023
View reviewed changes
code/app-util-xdm/build.gradle
}

dependencies {
implementation project(':edge')
Copy link
Copy Markdown
Contributor

@addb addb Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move this xdm https://github.com/adobe/aepsdk-edge-android/blob/dev-v2.0.0/code/edge/src/main/java/com/adobe/marketing/mobile/xdm/Property.java
to the tester package we can remove edge project dependency right?

Copy link
Copy Markdown
Contributor Author

@emdobrin emdobrin Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot move it, is part of the Edge SDK

Copy link
Copy Markdown
Contributor

@addb addb Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move as in create a copy of it in the tester package.

Copy link
Copy Markdown
Contributor Author

@emdobrin emdobrin Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not make much sense to copy them. The Edge extension provides them for Schema implementors, hence the dependency on Edge SDK for this util lib.

addb
addb approved these changes Jan 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@addb addb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few nit comments. Overall it looks good!

@emdobrin emdobrin merged commit fb47439 into adobe:dev-v2.0.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addb addb addb approved these changes

@kevinlind kevinlind Awaiting requested review from kevinlind

@cacheung cacheung Awaiting requested review from cacheung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kotlin test app for integration testing

2 participants

@emdobrin @addb