Merged
Conversation
Closed
Add Documentation for getSharedState API for 3rd Party Ext
cdhoffmann
requested changes
May 23, 2022
Contributor
cdhoffmann
left a comment
There was a problem hiding this comment.
Just a few things to fix and we can merge this in.
- The review comments related to the version bump
- Need to fix the merge conflicts.
- Finally, sign the Adobe CLA please so that you can contribute. The link is below on the CI automated output.
We will be adding some testing and automation scripts to our CI for full tvOS support. Thanks for contributing!
…-support # Conflicts: # AEPCore.podspec # AEPIdentity.podspec # AEPLifecycle.podspec # AEPServices.podspec # AEPServices/Sources/ServiceProvider.swift # AEPServices/Sources/ui/AEPUIService.swift # AEPServices/Sources/ui/UIService.swift # AEPServices/Sources/ui/fullscreen/FullscreenMessage+FrameCalculation.swift # AEPServices/Sources/ui/fullscreen/FullscreenMessage+WKNavigationDelegate.swift # AEPServices/Sources/ui/fullscreen/FullscreenMessage+WKScriptMessageHandler.swift # AEPServices/Sources/ui/fullscreen/FullscreenMessage.swift # AEPServices/Sources/ui/fullscreen/FullscreenMessageDelegate.swift # AEPSignal.podspec
Codecov Report
@@ Coverage Diff @@
## dev-v3.6.1 #798 +/- ##
==============================================
- Coverage 88.22% 88.20% -0.02%
==============================================
Files 129 129
Lines 5749 5755 +6
==============================================
+ Hits 5072 5076 +4
- Misses 677 679 +2 |
Contributor
Author
|
@cdhoffmann I've completed all the steps. Please align your branch (adobe:dev-v3.6.1) to main before merging this PR because I took the latest changes from there first and it seems there is one more commit with documentation changes which is currently appear here and missing on your branch. |
cdhoffmann
approved these changes
May 24, 2022
Contributor
cdhoffmann
left a comment
There was a problem hiding this comment.
Changes look good. Thanks again for your contribution.
This was referenced May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding tvOS support to allow using AEP with tvOS
All iOS only related classes are marked as limited to iOS to allow compiling correctly for tvOS
Related Issue
Motivation and Context
Adding tvOS support to allow using AEP with tvOS
All iOS only related classes are marked as limited to iOS to allow compiling correctly for tvOS
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: