Merged
Conversation
Staging to main for v5.7.0
…ore-ios into feat/ReEvaluation
…reevaluation APIs to AEPCore
…reevaluation APIs to AEPCore
…ore-ios into feat/ReEvaluation # Conflicts: # API/AEPCore-ios.json # API/AEPCore-tvos.json
…terceptor instead of passing the original event
Added reEvaluation support for rules engine
Updating version to 5.8.0
cdhoffmann
approved these changes
Feb 9, 2026
sbenedicadb
requested changes
Feb 10, 2026
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
a couple very small requests
| @@ -0,0 +1,42 @@ | |||
| /* | |||
| Copyright 2020 Adobe. All rights reserved. | |||
Member
There was a problem hiding this comment.
new file copyrights must include the current year. please change to 2026
Comment on lines
+22
to
+27
| static let reevaluableConsequenceTypes: Set<String> = ["schema"] | ||
|
|
||
| /// Indicates whether this rule should trigger re-evaluation when matched. | ||
| /// Reads from `meta["reEvaluate"]`, defaults to `false` if not present. | ||
| public var reevaluable: Bool { | ||
| return meta?["reEvaluate"] as? Bool ?? false |
Member
There was a problem hiding this comment.
nit: move both of these magic strings to the constants file
Comment on lines
+18
to
+29
| public protocol RuleReevaluationInterceptor: AnyObject { | ||
| /// Called when reevaluable rules match an event | ||
| /// - Parameters: | ||
| /// - event: The event that triggered the rules | ||
| /// - reevaluableRules: Rules marked as reevaluable | ||
| /// - completion: Call when done to trigger re-evaluation | ||
| func onReevaluationTriggered( | ||
| event: Event, | ||
| reevaluableRules: [LaunchRule], | ||
| completion: @escaping () -> Void | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
nit: would prefer having this protocol defined in its own file.
sbenedicadb
reviewed
Feb 11, 2026
…reference in reevaluationInterceptor and removed AnyCodable from reEvaluation public protocol, also addressed PR comments and updated tests.
Added boolean in completion of onReEvaluationTriggered.
sbenedicadb
approved these changes
Feb 12, 2026
Updated config.yml file for circle CI checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: