Replace unsafe ClassFinder with ExtensionFinder to resolve crashes#1180
Merged
praveek merged 1 commit intoadobe:dev-v5.6.2from Sep 5, 2025
Merged
Replace unsafe ClassFinder with ExtensionFinder to resolve crashes#1180praveek merged 1 commit intoadobe:dev-v5.6.2from
praveek merged 1 commit intoadobe:dev-v5.6.2from
Conversation
cdhoffmann
approved these changes
Sep 4, 2025
kevinlind
approved these changes
Sep 5, 2025
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Looks good. Added one small suggestion.
| private static let LOG_TAG = "ExtensionFinder" | ||
|
|
||
| // EventHub automatically registers Configuration and the Placeholder extensions, don't include them to prevent duplicate registration warnings. | ||
| private static let adobeExtensionClassNames = [ |
Contributor
There was a problem hiding this comment.
I feel if will be easier to maintain this list if included in the CoreConstants file. Can it be moved there?
Contributor
Author
There was a problem hiding this comment.
I’ll keep everything self-contained in this file for now until we decide on an approach for third-party extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crashes still occur intermittently when iterating over the list returned by
objc_getClassListorobjc_copyClassList.I suspect two possible causes:
objc_getClassListcrashed with an iOS 16 available class, in device that lower than iOS 16 swiftlang/swift#61215).For now,