Update ClassFinder to use objc_copyClassList instead of objc_getClassList#1175
Merged
praveek merged 1 commit intoadobe:dev-v5.6.1from Aug 15, 2025
Merged
Update ClassFinder to use objc_copyClassList instead of objc_getClassList#1175praveek merged 1 commit intoadobe:dev-v5.6.1from
praveek merged 1 commit intoadobe:dev-v5.6.1from
Conversation
cdhoffmann
approved these changes
Aug 14, 2025
kevinlind
approved these changes
Aug 14, 2025
|
@praveek FYI. this crash seems to still be happening for us on 5.6.1 |
Contributor
Author
|
@joonmanji If you have a crash report, could you share it in #1174? Also, is this happening in a RN app or a native app, and could you provide the list of other dependencies as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1174
Using
objc_copyClassListis safer thanobjc_getClassListbecause it returns the entire list of classes in a single, fully allocated buffer. Withobjc_getClassList, we make the call twice and the number of classes can change between calls as new classes are registered. Although the class count should only increase, we have observed crashes caused by accessing null pointers or corrupted memory. I suspect part of the buffer we provide toobjc_getClassListisn’t being filled correctly, and switching toobjc_copyClassListshould improve stability by providing a complete, reliable buffer containing all classes.https://developer.apple.com/forums/thread/700770