Skip to content

Update historical consequence to dispatch entire rules consequence#1158

Merged
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom
timkimadobe:update-historical-consequence-event
Jul 17, 2025
Merged

Update historical consequence to dispatch entire rules consequence#1158
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom
timkimadobe:update-historical-consequence-event

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

Description

This PR updates the rules engine historical condition operation to dispatch the entire rules consequence object in its dispatched consequence instead of just the recorded event, for better identification of the consequence in downstream use cases like Messaging extension's handling of content card qualification, unqualification, and disqualification.

It leverages the existing logic to create such a consequence event in: generateConsequenceEvent (and thus also follows the existing event data structure used by that method)

It also updates the test cases to cover the new split recorded and dispatched consequence events.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe merged commit 95f8b6c into adobe:feature/historical-consequence Jul 17, 2025
17 checks passed
@timkimadobe timkimadobe deleted the update-historical-consequence-event branch July 17, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants