Update historical consequence to dispatch entire rules consequence#1158
Merged
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom Jul 17, 2025
Conversation
…eEvent method to dispatch consequence Update test cases
spoorthipujariadobe
approved these changes
Jul 16, 2025
95f8b6c
into
adobe:feature/historical-consequence
17 checks passed
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the rules engine historical condition operation to dispatch the entire rules consequence object in its dispatched consequence instead of just the recorded event, for better identification of the consequence in downstream use cases like Messaging extension's handling of content card qualification, unqualification, and disqualification.
It leverages the existing logic to create such a consequence event in:
generateConsequenceEvent(and thus also follows the existing event data structure used by that method)It also updates the test cases to cover the new split recorded and dispatched consequence events.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: