Test coverage for JSONCondition getHistoricalEventCount (search type any or ordered)#1142
Merged
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom Jun 11, 2025
Conversation
spoorthipujariadobe
requested changes
Jun 2, 2025
spoorthipujariadobe
left a comment
There was a problem hiding this comment.
Looks like some other PR merge created some conflicts for this PR 😶
9a59730 to
3d2e5bf
Compare
spoorthipujariadobe
approved these changes
Jun 11, 2025
b5965b5
into
adobe:feature/historical-consequence
17 checks passed
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is based on the implementation of
mostRecentin (and this diff currently also contains its changes):mostRecentsearch type for rules historical condition #1138Once #1138 is merged, this PR should reflect the actual scope of changes.
Questions for reviewers
getHistoricalEventCountwhy do missing input values return 0? Isn't this an error case? 0 is a meaningful return for both search types, but I wonder if changing this to-1is a breaking change?aepsdk-core-ios/AEPCore/Sources/rules/JSONRulesParser.swift
Lines 180 to 186 in c3727f6
Description
This PR adds unit test coverage for
JSONCondition'sgetHistoricalEventCountmethod:Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: