EventHistory get multiple event test cases#1141
Merged
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom Jun 10, 2025
Merged
EventHistory get multiple event test cases#1141timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom
timkimadobe merged 2 commits intoadobe:feature/historical-consequencefrom
Conversation
… than one" event case Update MockEventHistoryDatabase to enable this testing
spoorthipujariadobe
approved these changes
Jun 2, 2025
32e4b95
into
adobe:feature/historical-consequence
17 checks passed
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two test cases for EventHistory's
getEventsmethod, validating that:testGetEvents_MultipleRequests_EnforceOrder_UsesPreviousOldest: When using ordered search, it properly uses the oldest occurrence date of the first result as the starting time range for the next eventtestGetEvents_MultipleRequests_NoOrder_ReturnsResultsInSameOrder: When more than one event is passed, results are returned in the same orderThis PR adds two test cases for
EventHistory’sgetEventsmethod, validating:testGetEvents_MultipleRequests_EnforceOrder_UsesPreviousOldestenforceOrderis enabled, thefromtimestamp for each following request is correctly using theoldestOccurrenceof the previous result.testGetEvents_MultipleRequests_NoOrder_ReturnsResultsInSameOrderenforceOrderdisabled, the results are returned in the same order as the requests.To support testing this multi-event
getEventscase,MockEventHistoryDatabasehas been updated to allow:returnSelectResultsQueue, which acts as a FIFO queue.paramproperties has been updated to use an array backing, allowing capture of multiple sets of parameters from method calls.paramproperties into computed.lastaccessors of the backing arrays.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: