Test coverage for JSONCondition getMostRecentHistoricalEvent (search type mostRecent)#1140
Merged
timkimadobe merged 4 commits intoadobe:feature/historical-consequencefrom May 29, 2025
Conversation
mostRecent search type for rules historical conditiongetMostRecentHistoricalEvent (search type mostRecent)
spoorthipujariadobe
approved these changes
May 29, 2025
1bb0bda
into
adobe:feature/historical-consequence
17 checks passed
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR is based on the implementation of
mostRecentin (and this diff currently also contains its changes):mostRecentsearch type for rules historical condition #1138Once #1138 is merged, this PR should reflect the actual scope of changes.
Description
This PR adds test coverage for the new
mostRecentsearch type in rules historical conditions.JSONConditionMostRecentTests (new!)
JSONConditionwhosegetMostRecentHistoricalEventcan be tested-1-10when there's a single result with a valid timestampRulesEngineFunctionalTests
mostRecentcondition in a consequence correctly evaluating to:Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: