Skip to content

Fix TokenReplacementTests to be included in test suite#1139

Merged
timkimadobe merged 3 commits intoadobe:dev-v5.5.0from
timkimadobe:fix-missing-token-replacement-test
Apr 29, 2025
Merged

Fix TokenReplacementTests to be included in test suite#1139
timkimadobe merged 3 commits intoadobe:dev-v5.5.0from
timkimadobe:fix-missing-token-replacement-test

Conversation

@timkimadobe
Copy link
Copy Markdown
Contributor

@timkimadobe timkimadobe commented Apr 29, 2025

Description

This PR fixes the TokenReplacementTests to be included in the AEPCore test suite, as I believe it was omitted when originally created (I tried searching through the git logs for this file name in the AEPCore.xcodeproj/project.pbxproj, but found no entries)

It also creates a new TestableTraversable test helper as the previous as! Traversable cast on a base Dictionary no longer works.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@timkimadobe timkimadobe requested a review from cdhoffmann April 29, 2025 20:49
@timkimadobe timkimadobe merged commit 6d1f7e5 into adobe:dev-v5.5.0 Apr 29, 2025
17 checks passed
@timkimadobe timkimadobe deleted the fix-missing-token-replacement-test branch April 29, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants