Skip to content

Bugfix : Reframing IAM during iPad splitScreen#1102

Merged
PravinPK merged 2 commits intoadobe:dev-v5.3.2from
PravinPK:dev-v5.3.2
Dec 3, 2024
Merged

Bugfix : Reframing IAM during iPad splitScreen#1102
PravinPK merged 2 commits intoadobe:dev-v5.3.2from
PravinPK:dev-v5.3.2

Conversation

@PravinPK
Copy link
Copy Markdown
Contributor

@PravinPK PravinPK commented Nov 21, 2024

Fixed a FullScreenMessage bug that does not redraw when the application enters split screen mode.

Used NSKeyValueObservation to observer changes to the Application's key UIWindow's frame to detect device rotation and split screen size change.

The fix is tested on following Apps

  • Application based on Scene Delegate
  • Application based on UIAppDelegate lifecycle
  • Complete SwiftUI Application

The fix was tested on various orientation and status bar settings
Screenshot 2024-11-21 at 3 47 27 PM

The fix is tested on the following devices

  • iPhone 18 Simulator
  • iPhone 18 device
  • iPad 18 Simulator
  • iPad 14 device

Simulator Screen Recording - iPad Pro - 2024-11-21 at 14 44 13

@PravinPK PravinPK changed the title Bugfix : Reframing IAM during iPad splitScreen [WIP] Bugfix : Reframing IAM during iPad splitScreen Nov 21, 2024
NotificationCenter.default.addObserver(self,
selector: #selector(self.handleDeviceRotation(notification:)),
name: UIDevice.orientationDidChangeNotification,
object: nil)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to for listen for notification : UIDevice.orientationDidChangeNotification
Because windowFrameObserver will also gets triggered when the device orientation changes

Copy link
Copy Markdown
Member

@sbenedicadb sbenedicadb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy!

@PravinPK PravinPK merged commit 61e1666 into adobe:dev-v5.3.2 Dec 3, 2024
@PravinPK PravinPK changed the title [WIP] Bugfix : Reframing IAM during iPad splitScreen Bugfix : Reframing IAM during iPad splitScreen Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants