Dispatch consequence in an rules consequence event if schema type is not eventHistory#766
Merged
spoorthipujariadobe merged 1 commit intoadobe:feature/disqualificationfrom Jun 17, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/disqualification #766 +/- ##
==============================================================
+ Coverage 75.25% 75.25% +0.01%
Complexity 2337 2337
==============================================================
Files 217 217
Lines 10891 10894 +3
Branches 1411 1411
==============================================================
+ Hits 8195 8198 +3
Misses 2056 2056
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
timkimadobe
approved these changes
Jun 10, 2025
Contributor
timkimadobe
left a comment
There was a problem hiding this comment.
Looks great, thank you!
10 tasks
153dca0
into
adobe:feature/disqualification
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore existing behavior of dispatching consequence in a rules response content event for
schematype if thedetailis not of typehttps://ns.adobe.com/personalization/eventHistoryOperationRelated Issue
Motivation and Context
For non event history write cases, we still need to dispatch the consequence so Messaging SDK can use it to display in-app message or content card
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: