Skip to content

New JSONUtils and MapUtils#328

Merged
praveek merged 2 commits intoadobe:dev-v2.0.0from
emdobrin:coreutils
Jan 13, 2023
Merged

New JSONUtils and MapUtils#328
praveek merged 2 commits intoadobe:dev-v2.0.0from
emdobrin:coreutils

Conversation

@emdobrin
Copy link
Copy Markdown
Contributor

@emdobrin emdobrin commented Jan 13, 2023

Description

Convenience JSONUtils and MapUtils used by multiple extensions.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2023 •
edited
Loading

Codecov Report

Merging #328 (bedd9f9) into dev-v2.0.0 (418b1c9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##             dev-v2.0.0     #328      +/-   ##
================================================
+ Coverage         73.93%   73.96%   +0.03%     
- Complexity         1997     2016      +19     
================================================
  Files               174      175       +1     
  Lines              8946     8957      +11     
  Branches           1176     1178       +2     
================================================
+ Hits               6614     6625      +11     
  Misses             1813     1813              
  Partials            519      519
Flag Coverage Δ
functional-tests 18.95% <0.00%> (-0.02%) ⬇️
unit-tests 66.74% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/com/adobe/marketing/mobile/util/JSONUtils.java 95.83% <100.00%> (+0.38%) ⬆️
...java/com/adobe/marketing/mobile/util/MapUtils.java 100.00% <100.00%> (ø)
...obe/marketing/mobile/internal/eventhub/EventHub.kt 89.36% <0.00%> (-0.56%) ⬇️
...ing/mobile/internal/eventhub/ExtensionContainer.kt 55.96% <0.00%> (+1.04%) ⬆️

@emdobrin emdobrin mentioned this pull request Jan 13, 2023
Closed
@praveek praveek merged commit b71d77e into adobe:dev-v2.0.0 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@praveek praveek praveek approved these changes

@prudrabhat prudrabhat Awaiting requested review from prudrabhat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emdobrin @praveek