Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 4.0.0#98
Merged
kevinlind merged 16 commits intoadobe:dev-v4.0.0from Jun 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v4.0.0 #98 +/- ##
==============================================
+ Coverage 86.86% 92.14% +5.28%
==============================================
Files 14 14
Lines 1119 1590 +471
==============================================
+ Hits 972 1465 +493
+ Misses 147 125 -22 |
praveek
reviewed
Jun 5, 2023
kevinlind
reviewed
Jun 5, 2023
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
- Update
test-SPM.shwith ios 11, tvos11 and remove builds for i386 - Update
test-podspec.shwith ios 11 and tvos 11
kevinlind
reviewed
Jun 5, 2023
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
- Update
test-SPM.shwith ios 11, tvos11 and remove builds for i386 - Update
test-podspec.shwith ios 11 and tvos 11
emdobrin
reviewed
Jun 6, 2023
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
looks good once the other comments are updated
emdobrin
approved these changes
Jun 6, 2023
Contributor
|
Search for aep-sdks.gitbook.io, there are two locations we need to update to the new doc locations. |
kevinlind
approved these changes
Jun 6, 2023
cacheung
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Min supported version to iOS 11, tvOS 11 and Xcode 14.1 + Extension version Bump to 4.0.0.
Update SwiftLint to 0.52.0 and fix warnings.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: