Add Empty check for trackState and trackAction scenarios#97
Merged
addb merged 2 commits intoadobe:dev-v4.0.0from Jun 5, 2023
Merged
Add Empty check for trackState and trackAction scenarios#97addb merged 2 commits intoadobe:dev-v4.0.0from
addb merged 2 commits intoadobe:dev-v4.0.0from
Conversation
Add Empty check for trackState and trackAction scenarios. When the state is empty, set the default page name to client app id.
Codecov Report
@@ Coverage Diff @@
## dev-v3.2.1 #97 +/- ##
===========================================
Coverage 86.86% 86.86%
===========================================
Files 14 14
Lines 1119 1119
===========================================
Hits 972 972
Misses 147 147 |
timkimadobe
reviewed
May 17, 2023
Contributor
timkimadobe
left a comment
There was a problem hiding this comment.
Should we also include the new test cases added to the AnalyticsTrackTestBase in the app extension test class too?: AnalyticsAppExtTrackTests.swift
Update indent format and add test cases to AnalyticAppExtTrackTest.swf
emdobrin
approved these changes
Jun 2, 2023
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Empty check for trackState and trackAction scenarios.
When the state is empty, set the default page name to client app id.
Add tests.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: