Route resetIdentities event though event handler to avoid potential data race#83
Merged
addb merged 3 commits intoadobe:dev-v3.2.1from Dec 16, 2022
Merged
Conversation
Contributor
|
@timkimadobe can you take a quick look at the build/test failures? |
addb
requested changes
Dec 16, 2022
Codecov Report
@@ Coverage Diff @@
## dev-v3.2.1 #83 +/- ##
==============================================
+ Coverage 86.83% 86.86% +0.04%
==============================================
Files 14 14
Lines 1116 1119 +3
==============================================
+ Hits 969 972 +3
Misses 147 147 |
addb
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the routing of
resetIdentitiesevent through thehandleIncomingEventhandler so that it is handled within the sameDispatchQueueas all other events, avoiding potential race condition (thanks to Praveen V for identifying this issue!).Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: