Skip to content

Restructuring the getApplicationStateVar to return string#74

Merged
kevinlind merged 2 commits intoadobe:mainfrom
cdhoffmann:fixSPMScopeError
May 12, 2022
Merged

Restructuring the getApplicationStateVar to return string#74
kevinlind merged 2 commits intoadobe:mainfrom
cdhoffmann:fixSPMScopeError

Conversation

@cdhoffmann
Copy link
Copy Markdown
Contributor

@cdhoffmann cdhoffmann commented May 12, 2022 •
edited
Loading

Building the SDK for SPM resulted in the following error:

/Users/runner/work/aepsdk-analytics-ios/aepsdk-analytics-ios/AEPAnalytics/Sources/Analytics.swift:26:47: error: cannot find type 'UIApplication' in scope
    override func getApplicationStateVar() -> UIApplication.State? {
                                              ^~~~~~~~~~~~~
/Users/runner/work/aepsdk-analytics-ios/aepsdk-analytics-ios/AEPAnalytics/Sources/Analytics.swift:26:19: error: method does not override any method from its superclass
    override func getApplicationStateVar() -> UIApplication.State? {
    ~~~~~~~~      ^
/Users/runner/work/aepsdk-analytics-ios/aepsdk-analytics-ios/AEPAnalytics/Sources/Analytics.swift:707:50: error: cannot find type 'UIApplication' in scope
    fileprivate func getApplicationStateVar() -> UIApplication.State? {
                                                 ^~~~~~~~~~~~~

** ARCHIVE FAILED **

Restructuring the getApplicationStateVar to return string instead fixes the issue.

@cdhoffmann cdhoffmann requested a review from kevinlind May 12, 2022 23:25
@codecov
Copy link
Copy Markdown

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #74 (67ed843) into main (d89ae6b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files          14       14           
  Lines        1116     1116           
=======================================
  Hits         1007     1007           
  Misses        109      109

@cdhoffmann cdhoffmann changed the title add uikit import Restructuring the getApplicationStateVar to return string May 12, 2022
@kevinlind kevinlind merged commit 0d7036d into adobe:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinlind kevinlind kevinlind approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdhoffmann @kevinlind