[MOB-15997] Analytics app extension support#70
Conversation
kevinlind
left a comment
There was a problem hiding this comment.
Are most of the new test cases for the AnalyticsAppExtension just copies of the Analytics tests? If so, could you point out where you made changes for the app extension tests?
AEPAnalytics/Tests/FunctionalTests/AnalyticsAppExtConsequenceTests.swift
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.4 adobe/aepsdk-analytics-ios#70 +/- ##
==============================================
+ Coverage 90.21% 90.23% +0.03%
==============================================
Files 14 14
Lines 1113 1116 +3
==============================================
+ Hits 1004 1007 +3
Misses 109 109 |
| @@ -1,46 +0,0 @@ | |||
| PODS: | |||
There was a problem hiding this comment.
Why delete the Podfile.lock? Was this a mistake?
There was a problem hiding this comment.
I was getting a CI cocoapods error where it said it couldn't find 3.6.0 so i wanted to see if removing the podfile.lock would fix it. And it did.
There was a problem hiding this comment.
Can you try adding the --repo-update flag to bundle exec pod install --repo-update in the CircleCI config? Sounds like the repo on the CI node just needs to be updated.
| } | ||
|
|
||
| func invalidate() { | ||
| // TODO: perform invalidation of server connection if necessary |
There was a problem hiding this comment.
There are a lot of TODOs in this sample app. Is this work you'll do in another PR or is this FileProviderExtension a sample taken from someplace else and the actual implementation isn't needed for testing Analytics in an app extension?
There was a problem hiding this comment.
This is just Apple's template for a File Extension.
adobe/aepsdk-core-ios#812
Support for App Extensions. In order to support App Extensions we have used the @Availability attribute to mark the AnalyticsHelper is unavailable because it uses the UIApplication.shared instance. Then we made the Analytics Extension class a base class and created two children classes. One which will be used by Apps, and one which will be used by App Extensions when registering.