[MOB-14663] Remove AID generation logic.#52
Merged
kevinlind merged 5 commits intoadobe:dev-v3.0.3from Sep 10, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.3 #52 +/- ##
==============================================
- Coverage 91.20% 90.00% -1.20%
==============================================
Files 13 13
Lines 1170 1060 -110
==============================================
- Hits 1067 954 -113
- Misses 103 106 +3 |
Merge adobe/dev-v3.0.3 -> aidRemoval
kevinlind
requested changes
Sep 9, 2021
Contributor
kevinlind
left a comment
There was a problem hiding this comment.
Unless I'm not seeing these tests, can you add tests to verify handleAnalyticsRequestIdentityEvent will dispatch
- AID = nil if no AID is persisted
- AID = value if AID is persisted
Contributor
Author
|
Some of the tests are already present in AnalyticsIdTests. I have added more tests to cover other cases. |
kevinlind
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: