[MOB-14992] Clean Analytics context data. #48
Merged
praveek merged 1 commit intoadobe:dev-v3.0.2from Sep 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.2 #48 +/- ##
==============================================
- Coverage 90.07% 90.00% -0.07%
==============================================
Files 13 13
Lines 1158 1170 +12
==============================================
+ Hits 1043 1053 +10
- Misses 115 117 +2 |
sbenedicadb
approved these changes
Sep 8, 2021
Member
sbenedicadb
left a comment
There was a problem hiding this comment.
changes look good.
i'm wondering if we need to update docs and code documentation in MobileCore+Tracking.swift to indicate how the map gets filtered. the log is a good start, just wondering if there are other things we could do here to help alleviate confusion.
cdhoffmann
approved these changes
Sep 8, 2021
Contributor
Author
|
We can update Analytics documentation explaining how it filters context data from genericTrack requests. Should we update MobileCore+Tracking documentation as we don't filter anything from Core but given that Analytics extension is the main user of this API, we can add a note explaining how Analytics handles it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: