Handle reset identities event by addb · Pull Request #41 · adobe/aepsdk-analytics-ios

addb · 2021-05-20T23:23:27Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

codecov · 2021-05-21T01:05:41Z

Codecov Report

❗ No coverage uploaded for pull request base (dev-v3.0.3@61bd4ca). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             dev-v3.0.3      #41   +/-   ##
=============================================
  Coverage              ?   89.93%           
=============================================
  Files                 ?       13           
  Lines                 ?     1082           
  Branches              ?        0           
=============================================
  Hits                  ?      973           
  Misses                ?      109           
  Partials              ?        0

AEPAnalytics/Sources/Analytics.swift

AEPAnalytics/Sources/AnalyticsState.swift

…st for the same.

emdobrin

We should also add some integration tests with the other extensions, making sure the identities are reset accordingly and the new hits after reset contain the updated information.

AEPAnalytics/Sources/AnalyticsState.swift

AEPAnalytics/Sources/Analytics.swift

… event

…cess hit and dispatch response if the hit was queued after the resetIdentities event.

… get from systemInfoService in analyticsProperties.

AEPAnalytics/Sources/Analytics.swift

AEPAnalytics/Sources/AnalyticsHitProcessor.swift

…iew fixes.

…s-ios into AMSDK-11239

praveek · 2021-09-08T20:00:59Z

AEPAnalytics/Tests/FunctionalTests/AnalyticsIDTests.swift

+        dispatchDefaultConfigAndIdentityStates()
+        waitForProcessing()
+
+        let analyticsProperties = analytics.analyticsProperties


Let us not check internals in functional tests.

You can either check it in following requests or use getTrackingIdentifier/getVisitorIdentifier APIs

praveek · 2021-09-08T20:02:39Z

AEPAnalytics/Tests/FunctionalTests/AnalyticsIDTests.swift

+        dispatchDefaultConfigAndIdentityStates()
+        waitForProcessing()
+
+        let analyticsProperties = analytics.analyticsProperties


You can either check it in following requests or use getTrackingIdentifier/getVisitorIdentifier APIs

…sts.

emdobrin

@addb looks good with minor cleanup items 🕵️

AEPAnalytics/Sources/Analytics.swift

AEPAnalytics/Sources/AnalyticsHitProcessor.swift

AEPAnalytics/Sources/AnalyticsProperties.swift

AEPAnalytics/Sources/AnalyticsState.swift

AEPAnalytics/Tests/UnitTests/AnalyticsPropertiesTest.swift

praveek · 2021-10-13T15:46:06Z

AEPAnalytics/Sources/Analytics.swift

-    private var analyticsState: AnalyticsState
+
+    #if DEBUG
+        var analyticsProperties: AnalyticsProperties


Can we revert this if we are not accessing these two vars outside this class?

addb added 2 commits May 20, 2021 15:41

Handle generic resetIdentities event

a2de7db

Add unit and functional test for generic resetIdentities

b118ab2

addb requested review from cacheung, emdobrin, nporter-adbe and praveek May 20, 2021 23:23

fix tests

4e82c75

praveek reviewed May 24, 2021

View reviewed changes

AEPAnalytics/Sources/Analytics.swift Show resolved Hide resolved

praveek reviewed May 24, 2021

View reviewed changes

AEPAnalytics/Sources/AnalyticsState.swift Outdated Show resolved Hide resolved

Added logic to clear queued hits on resetIdentities event and unit te…

c94bf85

…st for the same.

emdobrin reviewed Jun 3, 2021

View reviewed changes

AEPAnalytics/Sources/AnalyticsState.swift Outdated Show resolved Hide resolved

AEPAnalytics/Sources/Analytics.swift Show resolved Hide resolved

addb added 5 commits June 4, 2021 13:57

Review fixed to only remove places data on reset identity

b3096ea

update shared state for all dependencies while handling configuration…

e817964

… event

update tests

6cc986d

Added logic to store timestamp for resetIdentities event and only pro…

4119f55

…cess hit and dispatch response if the hit was queued after the resetIdentities event.

Fix locale to be of type string and also cache the value of locale we…

43c6743

… get from systemInfoService in analyticsProperties.

praveek reviewed Jun 21, 2021

View reviewed changes

AEPAnalytics/Sources/Analytics.swift Outdated Show resolved Hide resolved

praveek reviewed Jun 21, 2021

View reviewed changes

AEPAnalytics/Sources/AnalyticsHitProcessor.swift Outdated Show resolved Hide resolved

praveek reviewed Jun 21, 2021

View reviewed changes

AEPAnalytics/Sources/AnalyticsHitProcessor.swift Show resolved Hide resolved

Removed logic to cache locale from analytics properties and other rev…

e74d990

…iew fixes.

praveek approved these changes Jun 21, 2021

View reviewed changes

nporter-adbe approved these changes Jul 2, 2021

View reviewed changes

addb added 3 commits July 2, 2021 11:40

updated dependency pods

1f6af2c

resolve merge conflicts

556ba32

Merge branch 'dev-v3.0.2' of https://github.com/adobe/aepsdk-analytic…

1d94c9b

…s-ios into AMSDK-11239

praveek approved these changes Aug 24, 2021

View reviewed changes

praveek reviewed Sep 8, 2021

View reviewed changes

praveek requested changes Sep 8, 2021

View reviewed changes

praveek changed the base branch from dev-v3.0.2 to dev-v3.0.3 September 9, 2021 02:43

addb added 4 commits September 9, 2021 10:59

Merge branch 'dev-v3.0.3' into AMSDK-11239

ee6fa2f

[AMSDK-11239] Removed the check on internal fields from functional te…

67d69b5

…sts.

Resolve merge conflicts

5032c0e

[AMSDK-11239] typo fix in comment

2c306dc

emdobrin reviewed Oct 12, 2021

View reviewed changes

[AMSDK-11239] cleanup and review fixes

19386e1

praveek reviewed Oct 13, 2021

View reviewed changes

praveek approved these changes Oct 13, 2021

View reviewed changes

emdobrin approved these changes Oct 13, 2021

View reviewed changes

[AMSDK-11239] Minor cleanup

08575b2

addb merged commit 499ca06 into adobe:dev-v3.0.3 Oct 13, 2021

Conversation

addb commented May 20, 2021

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

codecov bot commented May 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

emdobrin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

praveek Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

praveek Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

praveek Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

emdobrin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

praveek Oct 13, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented May 21, 2021 •

edited

Loading