Skip to content

Add AEPAnalytics.framework to SampleAPP#39

Merged
cacheung merged 9 commits intoadobe:dev-v3.0.2from
cacheung:codecov
May 5, 2021
Merged

Add AEPAnalytics.framework to SampleAPP#39
cacheung merged 9 commits intoadobe:dev-v3.0.2from
cacheung:codecov

Conversation

@cacheung
Copy link
Copy Markdown
Contributor

@cacheung cacheung commented Apr 20, 2021

Add AEPAnalytics.framework to SampleApp to fix an relaunch issue.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…mework to SampleApp

Update config.yml with SHA check for codecov
Add AEPAnalytics.framework to SampleApp
@cacheung cacheung requested review from addb and praveek April 20, 2021 05:29
fix unit test helper
added quote to codecov link
Add version info for codecov script
@emdobrin
Copy link
Copy Markdown
Contributor

@cacheung fixed the codecov step in #40 and merged into dev-v3.0.2, please fetch latest from there.

@cacheung cacheung changed the title Update config.yml with SHA check for codecov and add AEPAnalytics.framework to SampleAPP Add AEPAnalytics.framework to SampleAPP Apr 21, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2021

Codecov Report

Merging #39 (410e647) into dev-v3.0.2 (e1280f0) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           dev-v3.0.2      #39   +/-   ##
===========================================
  Coverage       90.07%   90.07%           
===========================================
  Files              13       13           
  Lines            1158     1158           
===========================================
  Hits             1043     1043           
  Misses            115      115           

update swift package Manager's dependency to version based.
fix an syntax
update package.swift
update swift package to version-based
@cacheung cacheung merged commit 0f67248 into adobe:dev-v3.0.2 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants