Skip to content

Fix bug in Places parsing where only String types are assumed#127

Merged
kevinlind merged 3 commits intoadobe:devfrom
kevinlind:mob-21198
Jun 25, 2024
Merged

Fix bug in Places parsing where only String types are assumed#127
kevinlind merged 3 commits intoadobe:devfrom
kevinlind:mob-21198

Conversation

@kevinlind
Copy link
Copy Markdown
Contributor

Description

Fixes bug in Places shared state parsing where String types are assumed. The Places shared state may contain other values types, such as numbers, booleans, doubles, and maps. If the Places shared state contained values other than String type then the parsing failed and the Places data was not added to the Analytics hit. This PR fixes that by reading the Places shared state as type Any, then reading the individual region name and ID as Strings.

See internal bug: MOB-21198

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kevinlind kevinlind requested review from PravinPK and praveek June 24, 2024 18:15
@kevinlind kevinlind merged commit 1fe5939 into adobe:dev Jun 25, 2024
@kevinlind kevinlind deleted the mob-21198 branch June 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants