Skip to content

Add logic to retry only for limited list of recoverable URLErrors#119

Merged
addb merged 7 commits intoadobe:devfrom
addb:retryUrlErrors
May 22, 2024
Merged

Add logic to retry only for limited list of recoverable URLErrors#119
addb merged 7 commits intoadobe:devfrom
addb:retryUrlErrors

Conversation

@addb
Copy link
Copy Markdown
Collaborator

@addb addb commented May 16, 2024

Description

Screenshot 2024-05-15 at 1 18 33 PM

  • Added logic to retry hits failed with a recoverable URLError, which were previously discarded.
  • Added tests.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@addb addb requested review from emdobrin and kevinlind May 16, 2024 01:09
@addb addb removed the request for review from emdobrin May 21, 2024 02:46
Copy link
Copy Markdown
Contributor

@kevinlind kevinlind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor suggestion to keep the functions smaller.

@addb addb requested a review from kevinlind May 22, 2024 20:46
@addb addb merged commit 261cc80 into adobe:dev May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants