Skip to content

Display banner.txt on CLI command#73

Merged
paulsmith merged 1 commit intoadhocteam:mainfrom
gmso:main
Jan 9, 2023
Merged

Display banner.txt on CLI command#73
paulsmith merged 1 commit intoadhocteam:mainfrom
gmso:main

Conversation

@gmso
Copy link
Contributor

@gmso gmso commented Jan 7, 2023

Closes #50

Intro

Hi! 👋 I'm Germán, a Software Engineer based in Maryland. I really like this project's goal and ideas so I would like to contribute if possible.

Seeing as this is my first PR on this project, I went ahead and tackled issue #50, since it has the good first issue tag.

Changes

  • Display the banner.txt when using the pushup command
  • The banner is embedded into the executable
  • The banner is not displayed when pushup -version is executed

Examples

$ pushup

        //                                                                  
     //  //      //////                        //                           
                //    //  //    //    //////  //////    //    //  //////    
               //////    //    //  ////      //    //  //    //  //    //   
              //        //    //      ////  //    //  //    //  //    //    
             //          //////  //////    //    //    //////  //////       
                                                              //            
                                                             //             

Usage: pushup [command] [options]

Flags:
 -version  Print the version number and exit

Commands:
 new [path]  create new Pushup project directory
 build       compile Pushup project and build executable
 run         build and run Pushup project app

$ pushup build

        //                                                                  
     //  //      //////                        //                           
                //    //  //    //    //////  //////    //    //  //////    
               //////    //    //  ////      //    //  //    //  //    //   
              //        //    //      ////  //    //  //    //  //    //    
             //          //////  //////    //    //    //////  //////       
                                                              //            
                                                             //             


$ pushup -version
Pushup 0.0.1

I hope I got the idea of this change right. If there are any suggestions or changes to be made, please let me know!

paulsmith
paulsmith approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@paulsmith paulsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @gmso. Thank you for your contribution! LGTM, :shipit:

@paulsmith paulsmith merged commit 7b9ec07 into adhocteam:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulsmith paulsmith paulsmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add startup banner

2 participants

@gmso @paulsmith