test: add VCR tests for google vision#1
Closed
codefromthecrypt wants to merge 6 commits intoadhintz:mainfrom
Closed
test: add VCR tests for google vision#1codefromthecrypt wants to merge 6 commits intoadhintz:mainfrom
codefromthecrypt wants to merge 6 commits intoadhintz:mainfrom
Conversation
Author
|
maybe we can do this later so that it doesn't drift based on this block#146 |
Owner
Sure! I'll wait to merge this PR until your pretty-printing JSON PR is merged. Thanks for making the VCR tests! |
4 tasks
23094d7 to
837dbdd
Compare
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
837dbdd to
0a25db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes block#141