fix(list_dir): add isdir check before listing#1540
Merged
bryanadenhq merged 1 commit intoaden-hive:mainfrom Jan 28, 2026
Merged
fix(list_dir): add isdir check before listing#1540bryanadenhq merged 1 commit intoaden-hive:mainfrom
bryanadenhq merged 1 commit intoaden-hive:mainfrom
Conversation
bryanadenhq
approved these changes
Jan 28, 2026
Collaborator
bryanadenhq
left a comment
There was a problem hiding this comment.
looks good, thanks for contributing!
jhalak999
pushed a commit
to jhalak999/hive
that referenced
this pull request
Feb 17, 2026
…r-check fix(list_dir): add isdir check before listing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed
list_dircrash when given a file path instead of a directory by addingos.path.isdir()validation.Type of Change
Related Issues
Fixes #1401
Changes Made
os.path.isdir()check after path existence validationNotADirectoryErrorexceptionTesting