Upload Espressif bootloader .zip and combined*.bin to board-specific dirs on S3#454
Conversation
hathach
left a comment
There was a problem hiding this comment.
look great, I don't know how to test this without an actual release as well, release on fork does not work since aws isn't valid. But this should be fine. I think we could change the upload aws using if fi to make it cleaner than ||, but that is optional :)
ac5fb6e to
1740fa6
Compare
1740fa6 to
aabf153
Compare
|
The sense of the conditional was backward; I force-pushed a change. |
hathach
left a comment
There was a problem hiding this comment.
perfect, I think we can merge and test release with revision bump
|
Do you want to do the merge? And did you mean do a release now? Thanks. |
yeah we can merge and then make an relesae to test with |
|
OK, it worked!
|
|
perfect !! :) |
|
@dhalbert there seems to have issue with uploading combined-ota.bin to s3 in release https://github.com/adafruit/tinyuf2/actions/runs/16029529896 |
|
fixed build with #456. The lasts command |
|
Thanks! I was following the previous style, but I understand now how it causes an issue. |
During a release
tinyuf2*.zipandupdate-tinyuf2*.uf2to a board-specific directory. The upload path used to be, for example:s3://adafruit-circuit-python/bootloaders/esp32/tinyuf2-adafruit_feather_esp32s3-0.32.0.zipand now it is
s3://adafruit-circuit-python/bootloaders/esp32/adafruit_feather_esp32s3/tinyuf2-adafruit_feather_esp32s3-0.32.0.zipThis groups by board name, and reduces the large number of files at one level in S3.
combined.binand, if it exists, thecombined-ota.bin. The files are renamed to include the board name and version, for exampletinyuf2-adafruit_feather_esp32s3-0.32.0-combined.binSee https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bootloaders/esp32/ for both old and new hiearchies.
@hathach I have tried to be careful about this, but I'm not sure how to test the uploads without doing a release. Could you double-check the paths? Thanks.
I have already copied files to board-specific dirs using a script for the previous releases. When this is merged I will submit a PR update https://github.com/adafruit/web-firmware-installer-js to look in the new locations, and after that's merged I'll delete old uploads that are in the top-level directory.