Skip to content

Add Waveshare ESP32-S3 Zero#412

Merged
hathach merged 3 commits into
adafruit:masterfrom
bill88t:master
Oct 22, 2024
Merged

Add Waveshare ESP32-S3 Zero#412
hathach merged 3 commits into
adafruit:masterfrom
bill88t:master

Conversation

@bill88t

@bill88t bill88t commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

Checklist

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

This checklist items that are not applicable to your PR can be deleted.


Description of Change

A board already ported to CircuitPython. Got it today, thankfully I don't need to go through the pid-aquiring process.

@bill88t

bill88t commented Oct 1, 2024

Copy link
Copy Markdown
Contributor Author

The neopixel has red and green inverted, added support for that with an #ifdef.

@bill88t bill88t marked this pull request as ready for review October 1, 2024 22:14
@bill88t

bill88t commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Is there an issue with the PR?

@hathach hathach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thank you

@hathach hathach merged commit 2e553ad into adafruit:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants