add missing _Val suffix on arguments to GCLK_GENCTRL_SRC()#366
Merged
hathach merged 1 commit intoadafruit:masterfrom Sep 9, 2025
Merged
add missing _Val suffix on arguments to GCLK_GENCTRL_SRC()#366hathach merged 1 commit intoadafruit:masterfrom
hathach merged 1 commit intoadafruit:masterfrom
Conversation
without the suffix, the value is erroneously being shifted twice, which happens to be harmless in these particular instances because the shift is by zero
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where clock source constants were missing the _Val suffix when passed to the GCLK_GENCTRL_SRC() macro, causing double shifting of values. The fix ensures proper clock configuration by using the correct constant values.
- Adds
_Valsuffix to clock source constants in macro calls - Fixes potential double-shifting issue in clock generator configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without the suffix, the value is erroneously being shifted twice, which happens to be harmless in these particular instances because the shift is by zero