Fix typo in samd51 clock init which was preventing XOSC1K from being used in RTCCTRL#278
Merged
hathach merged 2 commits intoadafruit:masterfrom Nov 15, 2022
rlcamp:master
Merged
Fix typo in samd51 clock init which was preventing XOSC1K from being used in RTCCTRL#278hathach merged 2 commits intoadafruit:masterfrom rlcamp:master
hathach merged 2 commits intoadafruit:masterfrom
rlcamp:master
Conversation
|
I had noticed this too, and also assumed that the intent was |
hathach
approved these changes
Nov 15, 2022
Member
hathach
left a comment
There was a problem hiding this comment.
great, thank you. You got an eagle eye 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the OSC32KCTRL_XOSC32K_EN32K bit was enabled twice and the OSC32KCTRL_XOSC32K_EN1K bit was missing, which looks like an obvious typo. Fixing this allows XOSC1K to be properly used in RTCCTRL.