Skip to content

Conversation

@jackton1
Copy link
Contributor

@jackton1 jackton1 commented Mar 9, 2024

Rationale

I updated the docs to highlight the user's perspective and the image to better guide a new user through setting up Workflow permissions.

jackton1 added 3 commits March 8, 2024 21:40
### Rationale
Since the steps above the image already highlight how to view/modify the default token permission having this image would be redundant.
@jackton1
Copy link
Contributor Author

jackton1 commented Mar 9, 2024

HI @ad-m can you take a look when you get a chance? Thanks

@jackton1 jackton1 requested a review from ZPascal June 27, 2024 16:20
@jackton1 jackton1 changed the title docs: remove redundant general setting image docs: improve documentation and update image Jun 27, 2024
Copy link
Collaborator

@ZPascal ZPascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Please adapt the spelling of GitHub. Thank you.

Co-authored-by: Pascal Zimmermann <pascal.zimmermann@theiotstudio.com>
@jackton1
Copy link
Contributor Author

LGTM in general. Please adapt the spelling of GitHub. Thank you.

@ZPascal Done

@ZPascal
Copy link
Collaborator

ZPascal commented Jun 29, 2024

@jackton1 Feel free to merge the PR.

@ZPascal ZPascal merged commit 77c5b41 into ad-m:master Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants