-
Notifications
You must be signed in to change notification settings - Fork 272
Incorrect URL for liveness check? #151
Copy link
Copy link
Closed
Description
Mentioned in the README
icanhasip.comis used to see if there is an internet connection
and it's implementation here:
battery/app/modules/battery.js
Line 123 in 79df4af
| exec_async( `${ path_fix } curl icanhasip.com &> /dev/null` ).then( () => true ).catch( () => false ), |
May this be changed?
The URL is not https, and according to https://radar.cloudflare.com/scan/d203c57e-b08e-4831-b278-68419aaf8bac/dom it doesn't seem to show anything of worth.
May this be changed to use https://icanhazip.com instead? Not only is it now owned by cloudflare, but it actually shows something useful.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels