Remove localhost connections from I/O unit tests#965
Merged
josephnoir merged 3 commits intomasterfrom Nov 10, 2019
Merged
Conversation
Merged
josephnoir
reviewed
Nov 9, 2019
Member
josephnoir
left a comment
There was a problem hiding this comment.
There are still tests that establish connections to localhost: typed_remote_actor and typed_broker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was motivated by #955, because the I/O unit tests fail on OpenBSD due to differences in how each OS handles localhost connections. Since this isn't the first time we're having trouble with our I/O unit tests because of this, I've ported all unit tests to the
io_dsl.hppheader. Some of the unit tests were also quite dated, had large overlaps, or were flat out weird (like thetriggeringunit test). The changes are substantial enough that I think discussing this separately from the actual OpenBSD changes makes more sense.I ended up consolidated a bunch of stuff such as the remote actor suite and its typed counterpart and dropped several tests that don't have clear, concise goal.