Skip to content

Fix verbosity level with disabled console output#953

Merged
Neverlord merged 1 commit intomasterfrom
topic/logger
Oct 29, 2019
Merged

Fix verbosity level with disabled console output#953
Neverlord merged 1 commit intomasterfrom
topic/logger

Conversation

@Neverlord
Copy link
Copy Markdown
Member

This bug produces a nasty deadlock in CAF if:

  • the default log level is > quiet
  • the user configures logger.file-verbosity = 'quiet'
  • the user sets logger.console = 'none' (default)

Now, the logger will not spin up its thread (neither terminal nor file output), but logger::accept happily returns true. Eventually, the ring buffer for the logger is full and the application comes to a grinding halt because no one ever reads from the queue.

Copy link
Copy Markdown
Member

@josephnoir josephnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Edit: We should still wait for Jenkins though ...

@Neverlord Neverlord merged commit 8607ad2 into master Oct 29, 2019
@Neverlord Neverlord deleted the topic/logger branch October 29, 2019 10:19
@Neverlord Neverlord removed the bug label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants