Polyamorous module#1113
Merged
scarroll32 merged 4 commits intoactiverecord-hackery:masterfrom Apr 4, 2020
Merged
Conversation
| .to match(%r{LEFT OUTER JOIN articles ON (\('default_scope' = 'default_scope'\) AND )?articles.person_id = people.id}) | ||
| expect(real_query) | ||
| .to match(%r{LEFT OUTER JOIN articles articles_people ON (\('default_scope' = 'default_scope'\) AND )?articles_people.person_id = parents_people.id}) | ||
| end |
Contributor
There was a problem hiding this comment.
If I recall correctly, this is the test that was failing on Rails 6-0-stable. Are you saying that the new query that ransack builds is correct? My understanding was that the CI failure was a real failure that should be fixed.
Member
There was a problem hiding this comment.
@deivid-rodriguez @varyonic this does seem to be passing the 6.0 CI, great work.
There was a problem hiding this comment.
I've added an example of a failing test in #1119 (comment)
If you change the order of your conditions, the test starts to fail and generates invalid SQL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumes #1105 Closes #1099 Fixes #1081 ?