Skip to content

feat(pieces): docsbot#9059

Merged
kishanprmr merged 8 commits intoactivepieces:mainfrom
LuizDMM:LuizDMM/issue9049
Sep 7, 2025
Merged

feat(pieces): docsbot#9059
kishanprmr merged 8 commits intoactivepieces:mainfrom
LuizDMM:LuizDMM/issue9049

Conversation

@LuizDMM
Copy link
Copy Markdown
Contributor

@LuizDMM LuizDMM commented Sep 4, 2025

What does this PR do?

This PR delivers the full implementation of the DocsBot integration, completing all the required actions with strong validation and type safety.

Completed Scope

  • Ask Question
  • Create Source
  • Upload Source File
  • Create Bot
  • Find Bot

How the Feature Works

All actions were fully implemented and carefully validated to prevent invalid requests. Every function is strongly typed according to the API documentation, ensuring reliability and maintainability.

The Create Source action includes a custom Zod schema that handles conditionally required fields, adding an extra layer of robustness to the validation process.

Additionally, here's a demo video showcasing the feature in action:

DocsBot.mp4

Fixes #9049
/claim #9049


Edit: Added demo video.

@algora-pbc algora-pbc bot mentioned this pull request Sep 4, 2025
@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

@kishanprmr @onyedikachi-david ready for a review in this one.

description:
'The question to ask the bot. 2 to 500 characters. Max increased to 8K tokens (roughtly 32k chars) when authenticated.',
}),
conversationId: Property.ShortText({
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it

Copy link
Copy Markdown
Collaborator

@sanket-a11y sanket-a11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check requested changes

@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

Hey @sanket-a11y, thank you for your review. I left some comments with questions. I'm currently validating the conditional required fields with a Zod Schema, as I pointed out in my comments, do you think that's enough? If not, where do you suggest me to make those checks?

@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

@sanket-a11y, implemented all other changes, only my question about the conditional validation to go.

@sanket-a11y
Copy link
Copy Markdown
Collaborator

@LuizDMM For the validation you can use the DynamicProperties prop

@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

@LuizDMM For the validation you can use the DynamicProperties prop

Got it, on it.

@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

@sanket-a11y Fixed the DynamicProperties with 475948c, ready for review and merge. Thank you again for the review and learning.

@LuizDMM
Copy link
Copy Markdown
Contributor Author

LuizDMM commented Sep 5, 2025

Just a demo with the DynamicProperties, the action is still working and now returning only the body, as required.

DocsBot2.mp4

sanket-a11y
sanket-a11y previously approved these changes Sep 7, 2025
@sanket-a11y sanket-a11y self-requested a review September 7, 2025 06:25
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Sep 7, 2025

View your CI Pipeline Execution ↗ for commit 8a57d63

Command Status Duration Result
nx run-many --target=test --projects=engine,sha... ✅ Succeeded 32s View ↗
nx run server-api:test-ce ✅ Succeeded 10s View ↗
nx run server-api:test-cloud ✅ Succeeded 9s View ↗
nx run server-api:test-ee ✅ Succeeded 4s View ↗
nx run-many --target=build -c production --proj... ✅ Succeeded 27s View ↗
nx affected --target=build -c production --excl... ✅ Succeeded <1s View ↗
nx run-many --target=lint --projects=pieces-doc... ✅ Succeeded 2m 31s View ↗
nx affected --target=lint --exclude=pieces-* --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-07 07:58:38 UTC

@kishanprmr kishanprmr merged commit 0d051c3 into activepieces:main Sep 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MCP] DocsBot

4 participants