feat: adding fireflies.ai piece#7607
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@AnkitSharmaOnGithub Please provide a video demonstrating the changes in this PR. |
|
Sure @kishanprmr. I have already mentioned it in the issue - #7606 (comment) |
|
Update - Also, adding videos for the demo. Please check link attached in the PR description. |
|
Update - |
|
@kishanprmr @ashrafsamhouri I have completed this piece. I have also recorded very detailed demo vide for the actions & triggers. Please find the link in the PR description. Thanks. |
|
@AnkitSharmaOnGithub I will review it soon. Thanks! |
|
@kishanprmr Please let me know, if I can be of any help to close this down sooner. |
|
please revisit the webhook trigger as fireflies doesn't have webhook endpoint. |
@kishanprmr Please correct me, if I am wrong here. The fireflies API does support web-hooks. Please check the docs here - https://docs.fireflies.ai/graphql-api/webhooks. Also, please check the attached images. I have also about it in the demo video.
|
|
@kishanprmr Please let me know, if any changes are required. For the trigger, please check the above comment. |
|
Thanks for the update. Since there is no webhook endpoint, but the PR contains a /webhook call inside the trigger, could you please revisit that? I believe it might throw an error. You can refer to the Moxie CRM piece trigger, where the user has to manually enter the webhookURL in the software. I assume it's the same case here. |
@kishanprmr I have updated the code as per the above comment. Request you to please review. |
|
@kishanprmr Request you to please review this PR. Please use your email address to access the demo videos. I have shared access to you & ash. |
|
View your CI Pipeline Execution ↗ for commit 8513bed. ☁️ Nx Cloud last updated this comment at |
|
Thank you for your awesome contribution! 🎉 |
|
Thanks @kishanprmr for the review. Awesome as always. |
iambenkay
left a comment
There was a problem hiding this comment.
@kishanprmr I was under the impression that quality was of utmost concern to the team at active pieces but it seems it is a first come first serve basis where there is no attention paid to quality of the code? I just want to know if that is how Pull Requests are graded at active pieces!
I have left some comments on this PR on several obvious issues that could introduce maintainability nightmares in the future.
I care about active pieces and that is why I am making these comments so they can be looked into.
The first to submit a PR isn't always the most well-written code.
Your team should gauge Low quality PRs and not accept them until they are up to standard! This is my opinion.
Thank you for your time
packages/pieces/community/fireflies-ai/src/lib/actions/find-meeting-by-query.ts
Show resolved
Hide resolved
packages/pieces/community/fireflies-ai/src/lib/actions/find-meeting-by-query.ts
Show resolved
Hide resolved
packages/pieces/community/fireflies-ai/src/lib/actions/find-recent-meeting.ts
Show resolved
Hide resolved
packages/pieces/community/fireflies-ai/src/lib/triggers/new-transcription-complete.ts
Show resolved
Hide resolved
|
I have noticed the same kind of errors by the same contributor on other PRs where some endpoints are hallucinated entirely. Endpoints which do not even exist on the docs but somehow he has implemented them in his PR. That should obviously be a giveaway that it was written with AI and not properly reviewed by him the author. Even in this PR, he originally used a non-existing webhook endpoint and published that as his final response. I am not clamoring to be the winner. Just saying that other people who want to contribute and see that the bar for acceptance is so low will not put in a better quality of code and may not even consider contributing for fear of investing too much and having a lower quality PR accepted. |
|
I thought I was the only one that noticed what @AnkitSharmaOnGithub was doing lol :) If you read the code, you'll see hallucinated endpoints, even if quality isn't the goal, shouldn't functionality be? @kishanprmr you need to take a look at this thread |
How are you confidently saying this @AnkitSharmaOnGithub |
|
I really appreciate you taking the time to share your thoughts — it’s clear that you care about the quality and future of Activepieces, and that means a lot. To clarify, we don’t merge PRs based on who submits them first. Every PR, especially those related to new actions or triggers, goes through a review process where we test the functionality, verify endpoints, and assess code quality. If any fake or incorrect endpoints are used, the PR simply won’t be merged. Regarding the webhook endpoint in the PR: you're right that it wasn’t listed in the official Fireflies API docs. I’ve already asked the contributor to remove it. FIreflies requires user to manually enter the webhook endpoint, that's why it has markdown description. Thanks again for pointing this out and for contributing to the project with both your code and your feedback. We hope you continue to be a part of Activepieces — your input is genuinely appreciated. |



What does this PR do?
This PR will add the Fireflies.ai ActivePiece. It is a meeting assistant that automatically records, transcribes, and analyzes conversations in the meetings.
How this will help the community
This integration enables Activepieces users to automate workflows around meetings, notes, and transcripts — ideal for sales, recruiting, and internal collaboration.
Demo Videos
Shared with the maintainers.
Explain How the Feature Works
This PR introduces a new ActivePiece integration for Fireflies.ai, a meeting assistant platform that records, transcribes, and analyses meeting conversations. The integration offers a variety of triggers and actions that can be used to build automated workflows involving meeting data.
🔄 Trigger
🔍 Search Actions
🛠️ Write Actions
📖 Read Actions
Relevant User Scenarios
This integration enhances productivity by automating routine meeting-related tasks. Here are key use cases:
Sales and CRM Automation
Internal Collaboration
Recruitment Workflows
Support Team Enablement
Data-Driven Reviews
Fixes #7606
/claim #7606
/closes #7606
/attempt #7606