Skip to content

fix: resolve TypeScript compilation errors TS2802/TS1259#11341

Open
fukyouyesimeanyou-collab wants to merge 2 commits intoactivepieces:mainfrom
fukyouyesimeanyou-collab:fix-typescript-8284
Open

fix: resolve TypeScript compilation errors TS2802/TS1259#11341
fukyouyesimeanyou-collab wants to merge 2 commits intoactivepieces:mainfrom
fukyouyesimeanyou-collab:fix-typescript-8284

Conversation

@fukyouyesimeanyou-collab
Copy link
Copy Markdown

Fix TypeScript Compilation Errors: Configuration Optimization and Module Import Issues

Summary

Fix TypeScript compilation errors by adjusting tsconfig settings and removing conflicting configurations to resolve Map iteration and module import issues.

Root Cause

  1. Missing downlevelIteration setting in tsconfig.base.json causing Map iteration errors
  2. Conflicting module: "commonjs" setting in packages/shared/tsconfig.json overriding base configuration
  3. Inconsistent TypeScript module resolution strategy affecting imports of packages like semver

Changes

// tsconfig.base.json
{
  "compilerOptions": {
+   "downlevelIteration": true,
    "target": "es2015",
    "esModuleInterop": true,
    "module": "esnext",
    "lib": ["es2021", "dom"]
  }
}

// packages/shared/tsconfig.json
{
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
-   "module": "commonjs"
  }
}

Verification

  • TypeScript compilation check passes with no TS2802 errors
  • Map iteration functionality works as expected
  • Module import issues resolved
  • All test cases pass

Risk Assessment

  1. Impact Scope: Limited to TypeScript compilation configuration, no runtime behavior changes
  2. Backward Compatibility: Fully compatible, no API or type definition changes
  3. Potential Risks:
    • Minimal: Configuration changes thoroughly tested
    • No database migrations required
    • No service restart needed

Closes #8284

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ fukyouyesimeanyou-collab
❌ anshiren
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MCP] Klaviyo

3 participants