Skip to content

Remove self-reference to ActiveAdmin node package #8847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tagliala merged 1 commit into from
Nov 5, 2025
Merged

Remove self-reference to ActiveAdmin node package #8847

tagliala merged 1 commit into from
Nov 5, 2025

Conversation

@tagliala
Copy link
Contributor

@tagliala tagliala commented Nov 5, 2025 •
edited
Loading

Additionally, update dependencies

Fix a regression introduced in f79eabd, where some lines were added
unintentionally to package.json

Additionally, update dependencies

I've tried to replicate how this initially happened but I didn't succeed

@codecov
Copy link

codecov bot commented Nov 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (0f0792d) to head (beff680).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8847   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files         139      139           
  Lines        4046     4046           
=======================================
  Hits         4009     4009           
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tagliala tagliala force-pushed the bugfix/8846-remove-self-reference-in-package-json branch from c4bf3c5 to 3e63059 Compare November 5, 2025 23:34
@tagliala tagliala marked this pull request as ready for review November 5, 2025 23:36
@tagliala tagliala marked this pull request as draft November 5, 2025 23:38
tagliala
tagliala commented Nov 5, 2025
View reviewed changes
@tagliala
Remove self-reference to ActiveAdmin node package
beff680 
Fix a regression introduced in f79eabd, where some lines were added
unintentionally to package.json

Additionally, update dependencies

Fix #8846
@tagliala tagliala force-pushed the bugfix/8846-remove-self-reference-in-package-json branch from 3e63059 to beff680 Compare November 5, 2025 23:42
tagliala
tagliala commented Nov 5, 2025
View reviewed changes
@tagliala tagliala marked this pull request as ready for review November 5, 2025 23:44
@tagliala tagliala merged commit 482fef4 into master Nov 5, 2025
29 checks passed
@tagliala tagliala deleted the bugfix/8846-remove-self-reference-in-package-json branch November 5, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tagliala