Update dependencies #8838
Merged
Update dependencies #8838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee40be0 to
db9072f
Compare
Set rubygems version in CI to 3.5.7 to make the CI pass against all the supported Ruby and Rails versions. "Gemfile sanity is up to date" was failing with `rubygems` set to `latest`
db9072f to
e2f02cc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and makes minor code adjustments. The main focus is on dependency version management across different configuration files.
Key Changes:
- Updated
gherkin-lintdependency version constraint in package.json - Refactored JavaScript helper functions with more compact syntax and reordered class inheritance
- Pinned rubygems version in CI workflow to ensure compatibility
Reviewed Changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Changed gherkin-lint from empty string to wildcard version constraint |
| app/assets/javascripts/active_admin/base.js | Refactored _inheritsLoose and _setPrototypeOf functions with terser syntax and moved inheritance call after constructor |
| .github/workflows/ci.yaml | Pinned rubygems to version 3.5.7 with explanatory comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@mgrunberg this is a pre-requirement for the attempt to test against Rails 8.1 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8838 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4971
Branches ? 0
=============================================
Hits ? 4931
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.