Skip to content

Conversation

@elthariel
Copy link
Contributor

@elthariel elthariel commented Jul 3, 2025

This PR adds a few missing locales for the french languages. Some of them are for aria-label tags, which somewhat breaks the display.

Note: The truncate field is not stricly necessary but I felt keeping the french locales matching the english one line by line would allow for easier maintenance

@elthariel
Copy link
Contributor Author

This is very similar in intent and purpose to #8732

@tagliala
Copy link
Contributor

tagliala commented Jul 3, 2025

Hello,

specs are failing because of i18n-tasks checks

Can you please run

bundle exec i18n-tasks normalize -l fr

and commit again?

you can see errors with

bundle exec i18n-tasks health -l fr

@tagliala tagliala self-requested a review July 3, 2025 11:57
'yes': Oui
toggle_main_navigation_menu: Bascule de menu principal
toggle_section: Bascule de Section
toggle_dark_mode: Bascule de Mode Sombre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sorted, please check my comment in the issue

@tagliala
Copy link
Contributor

tagliala commented Jul 8, 2025

Hi @elthariel,

Just a friendly ping regarding the changes I requested earlier. If you have any questions or need a hand figuring out the next steps, feel free to ask, I'm happy to help!

@tagliala
Copy link
Contributor

@elthariel another friendly ping. If you do not have time, I can do the changes myself and merge the PR when it is ready

@tagliala tagliala mentioned this pull request Jul 24, 2025
@tagliala
Copy link
Contributor

Superseded by #8770

@tagliala tagliala closed this Jul 24, 2025
@elthariel
Copy link
Contributor Author

Sorry @tagliala, I was in vacations.

@tagliala
Copy link
Contributor

tagliala commented Aug 7, 2025

No problem at all!

I hope you had a great vacation.

I've merged your work, preserving you as an author of the commits

If you'd like, feel free to make another review of the french translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants