-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add missing :fr locales #8754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing :fr locales #8754
Conversation
|
This is very similar in intent and purpose to #8732 |
|
Hello, specs are failing because of Can you please run and commit again? you can see errors with |
| 'yes': Oui | ||
| toggle_main_navigation_menu: Bascule de menu principal | ||
| toggle_section: Bascule de Section | ||
| toggle_dark_mode: Bascule de Mode Sombre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sorted, please check my comment in the issue
|
Hi @elthariel, Just a friendly ping regarding the changes I requested earlier. If you have any questions or need a hand figuring out the next steps, feel free to ask, I'm happy to help! |
|
@elthariel another friendly ping. If you do not have time, I can do the changes myself and merge the PR when it is ready |
|
Superseded by #8770 |
|
Sorry @tagliala, I was in vacations. |
|
No problem at all! I hope you had a great vacation. I've merged your work, preserving you as an author of the commits If you'd like, feel free to make another review of the french translation |
This PR adds a few missing locales for the french languages. Some of them are for
aria-labeltags, which somewhat breaks the display.Note: The
truncatefield is not stricly necessary but I felt keeping the french locales matching the english one line by line would allow for easier maintenance