Improve text color contrast #8535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8535 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 139 139
Lines 4043 4043
=======================================
Hits 4006 4006
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e126e2 to
7514b11
Compare
3c221ca to
c350e61
Compare
c350e61 to
2dc9983
Compare
8ae1397 to
9498eb2
Compare
af5cc45 to
3db9c13
Compare
Address accessibility issues identified by Lighthouse, focusing on improving the readability of form hint text in dark mode. - Enhance readability by making extra-small text darker in light mode - Refine dark theme color palette for improved contrast on non-black backgrounds: - Change some text colors from `gray-500` to `gray-400` - Update link color from `blue-600` to `blue-500`
3db9c13 to
18222b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address accessibility issues identified by Lighthouse, focusing on
improving the readability of form hint text in dark mode.
backgrounds:
gray-500togray-400blue-600toblue-500Before vs After
Form (dark) (Lighthouse Score: 92 -> 96)
URL:
http://localhost:5000/admin/stores/newLighthouse Report
Comment (light) (Lighthouse Score: 88 -> 88)
URL:
http://localhost:5000/admin/categories/2Comment (dark) (Lighthouse Score: 88 -> 88)
URL:
http://localhost:5000/admin/categories/2Lighthouse Report