Backport #8450 #8451 to 3.0 stable#8454
Merged
tagliala merged 2 commits intoactiveadmin:3-0-stablefrom Aug 24, 2024
Merged
Conversation
Relax sqlite3 version constraint because rails/rails#51636 is included in the latest 7.1.4 release
75e9453 to
fb09e5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8454 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4963
Branches ? 0
=============================================
Hits ? 4923
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fb09e5a to
b09cc52
Compare
Current bug report template does not work because sqlite3 2.x is not compatible with Rails 7.0.x. This commit also: - Test bug report template against Ruby 3.3 - Set config.eager_load to avoid a warning on stdout: ``` config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly: ``` - Default to `3-0-stable` branch when `ACTIVE_ADMIN_PATH` is not specified - Add `force_ruby_platform` to `sqlite3` for uniformity with `master` branch
b09cc52 to
ea48602
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8450
Backport #8451, plus an actual fix with the bug report template (it wasn't working because of sqlite, it is surprising that specs passed)